Fix mechRepr on controls to always return a native str.
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgedmin I am not sure why GitHub thinks that you are the author of this commit. Maybe my git-foo is only too little. |
|
@icemac have you perchance copied my |
mgedmin
requested changes
Oct 17, 2017
CHANGES.rst
Outdated
| @@ -5,7 +5,7 @@ CHANGES | |||
| 5.2.3 (unreleased) | |||
| ------------------ | |||
|
|
|||
| - Nothing changed yet. | |||
| - Fix ``mechRepr`` on controls to always return a native str. | |||
There was a problem hiding this comment.
Link to GitHub issue/pull request for more context?
| suite = unittest.TestSuite() | ||
| suite.addTests([ | ||
| unittest.makeSuite(TestDisplayValue), | ||
| unittest.makeSuite(TestMechRepr), |
There was a problem hiding this comment.
Instead of repeating unittest.makeSuite() for every test class, I recommend unittest.defaultTestLoader.loadTestsFromName(__name__), which finds all test classes automatically.
Fixes #38 As the scenario described in the ticket requires the `mechRepr` to be of the same type for all controls I decided to adapt the two remaining control classes which returned unicode to the str approach used by of the majority of the controls.
|
@mgedmin Thank you for your review. I fixed the commit as you suggested including the wrong author. (I am not re-using your config, maybe this was an error in my git client.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error scenario is the following:
browser.getControl()is used to select a not existing control.As the scenario described above requires the mechRepr to be of the same type I decided to adapt the two remaining control classes which returned unicode to the str approach used by of the majority of the controls.
Fixes #38.