Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for pystone as Python 3.7 dropped pystone. #50

Merged
merged 1 commit into from Oct 10, 2018
Merged

Drop support for pystone as Python 3.7 dropped pystone. #50

merged 1 commit into from Oct 10, 2018

Conversation

icemac
Copy link
Member

@icemac icemac commented Oct 9, 2018

  • Browser.lastRequestPystones no longer exists.
  • Rename .browser.PystoneTimer to .browser.Timer.

Drop support for pystone as Python 3.7 dropped pystone.
7a37632 
* `Browser.lastRequestPystones` no longer exists.
* Rename `.browser.PystoneTimer` to `.browser.Timer`.
@icemac icemac requested a review from mgedmin October 9, 2018 15:19
@icemac icemac added this to In progress in Zope 4 final release via automation Oct 9, 2018
@icemac icemac self-assigned this Oct 9, 2018
@icemac icemac requested a review from jamadden October 10, 2018 09:52
mgedmin
mgedmin approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Zope 4 final release automation moved this from In progress to Reviewer approved Oct 10, 2018
@icemac icemac merged commit 5a030fe into Python3.7support Oct 10, 2018
Zope 4 final release automation moved this from Reviewer approved to Done Oct 10, 2018
@icemac icemac deleted the drop-pystone branch October 10, 2018 10:53
@icemac
Copy link
Member Author

icemac commented Oct 10, 2018

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

@jamadden jamadden Awaiting requested review from jamadden

Assignees

@icemac icemac

Labels
None yet
Projects
No open projects
Zope 4 final release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icemac @mgedmin