Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all objects have consistent resolution orders. #93

Merged
merged 5 commits into from Jan 21, 2022
Merged

Conversation

janjaapdriessen
Copy link
Member

Trying to fix inconsistent iro with newest zope.interface.

@janjaapdriessen
Copy link
Member Author

@jamadden @mgedmin the work in this branch is inspired by your recent work on various zope.* packages, let me know if anything is missing.

Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing is missing, and that's Travis CI configuration for the environment variable.

Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also please add ZOPE_INTERFACE_STRICT_IRO=1 into .travis.yml

@icemac icemac merged commit 613a8b4 into master Jan 21, 2022
@icemac icemac deleted the consistent-iro branch January 21, 2022 07:09
@icemac
Copy link
Member

icemac commented Jan 21, 2022

Thank you for this PR and reviewing it. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants