Make sure Doctestcase __file__ attributes start with 'test' #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,8 @@ Changes | |||
| - Added meta data for test case methods created with | |||
| ``zope.testing.doctestcase``. | |||
|
|
|||
| - Reasonable values for __name__ | |||
| - Reasonable values for ``__name__``, making sure than ``__name__`` | |||
| starts with ``test``. | |||
|
👍 LGTM |
jimfulton
added a commit
that referenced
this pull request
Aug 31, 2015
Make sure Doctestcase __file__ attributes start with 'test'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem with the previous pull request. Unlike unittest and py.test, nose selects test class members based on name attribute (rather than on class dictionary keys). After we added setting name based on file or setup function names, I was finding that lots of tests were no-longer being run. (Some wouldn't have run with unittest's or pt.test's runners either). This PR adds a 'test_' prefix is name doesn't start with 'test'.