Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for issue 35 #66

Merged
merged 1 commit into from Nov 24, 2017
Merged

Workaround for issue 35 #66

merged 1 commit into from Nov 24, 2017

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Nov 23, 2017

See #35 for all
the gory details.

See #35 for all
the gory details.
@orivej
Copy link

orivej commented Nov 23, 2017

Thank you! This will prevent test failures in Nixpkgs.

@jamadden
Copy link
Member

I am currently traveling. It is likely to be some days before I have a chance to properly review anything.

@mgedmin
Copy link
Member Author

mgedmin commented Nov 23, 2017

I don't think this is particularly urgent.

Have a good Thanksgiving, or however you say it in your distant country!

Copy link
Member

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got time enough to review this PR between rounds of basting the turkey.

@mgedmin mgedmin merged commit aa7c9d1 into master Nov 24, 2017
@mgedmin mgedmin deleted the workaround-for-issue-35 branch November 24, 2017 11:49
orivej added a commit to NixOS/nixpkgs that referenced this pull request Nov 28, 2017
Upstream patch [1] does not apply because the file extension is different since [2].

[1] zopefoundation/zope.testrunner#66
[2] zopefoundation/zope.testrunner@666b71e
vcunat pushed a commit to NixOS/nixpkgs that referenced this pull request Dec 14, 2017
Upstream patch [1] does not apply because the file extension is different since [2].

[1] zopefoundation/zope.testrunner#66
[2] zopefoundation/zope.testrunner@666b71e

(cherry picked from commit 7df6853)
We do run into this flaky test relatively often on Hydra for 17.09, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants