Skip to content

Commit

Permalink
The TODO has been resolved since existing skins are preserved after +…
Browse files Browse the repository at this point in the history
…+error++debug.
  • Loading branch information
jamadden committed Mar 31, 2020
1 parent 84bca93 commit 3db6d45
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/zope/traversing/namespace.py
Expand Up @@ -685,11 +685,9 @@ def traverse(self, name, ignored):
elif flag == 'tal':
request.debug.showTAL = True
elif flag == 'errors':
# TODO: I am not sure this is the best solution. What
# if we want to enable tracebacks when also trying to
# debug a different skin?
# Note that we don't use applySkin(), because it removes all existing
# skins.
# skins. We may want to get tracebacks while trying to debug a
# different skin.
debug_skin = zope.component.getUtility(IBrowserSkinType, 'Debug')
alsoProvides(request, debug_skin)
else:
Expand Down

0 comments on commit 3db6d45

Please sign in to comment.