Skip to content
This repository has been archived by the owner on May 13, 2020. It is now read-only.

Commit

Permalink
something is wrong there with libxslt, log more output
Browse files Browse the repository at this point in the history
  • Loading branch information
@agroszer
agroszer committed Feb 7, 2014
1 parent 1db1743 commit 68266f6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/zope/wineggbuilder/lxml.py
View file
Expand Up @@ -132,7 +132,7 @@ def run(self, lxmlver):
command = self.compiler.setup + '\r\n' + cmd
command = command % idata
output = do(command, cwd=os.path.join(bdir, 'zlib'))
LOGGER.info('ZLIB build done')
LOGGER.info('ZLIB build done, output: \n%s', output)

######################
iconv = 'libiconv-%s.tar.bz2' % ICONVVER
Expand All @@ -147,7 +147,7 @@ def run(self, lxmlver):
shutil.copy(
os.path.join(iconvfolder, 'lib', 'iconv.lib'),
os.path.join(iconvfolder, 'lib', 'iconv_a.lib'))
LOGGER.info('ICONV build done')
LOGGER.info('ICONV build done, output: \n%s', output)

######################
libxml = 'libxml2-%s.tar.bz2' % LIBXMLVER
Expand All @@ -161,7 +161,7 @@ def run(self, lxmlver):
command = self.compiler.setup + '\r\n' + cmd1 + '\r\n' + cmd2
command = command % idata
output = do(command, cwd=os.path.join(bdir, 'libxml2', 'win32'))
LOGGER.info('LIBXML build done')
LOGGER.info('LIBXML build done, output: \n%s', output)

######################
libxslt = 'libxslt-%s.tar.bz2' % LIBXSLTVER
Expand All @@ -175,7 +175,7 @@ def run(self, lxmlver):
command = self.compiler.setup + '\r\n' + cmd1 + '\r\n' + cmd2
command = command % idata
output = do(command, cwd=os.path.join(bdir, 'libxslt', 'win32'))
LOGGER.info('LIBXSLT build done')
LOGGER.info('LIBXSLT build done, output: \n%s', output)

####################
url = LXMLURL % lxmlver
Expand Down

4 comments on commit 68266f6

@mgedmin
Copy link
Member

@mgedmin mgedmin commented on 68266f6 Feb 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there really something wrong with libxslt?

The lxml 3.3.0 build currently fails because of a bug in lxml, that is already fixed in master. When lxml 3.3.1 comes out to PyPI, the wineggbuilder should be able to build it fine.

@agroszer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have been distracted by
http://winbot.zope.org/builders/wineggbuilder/builds/48385/steps/release%20eggs/logs/stdio

c:\temp\lxmlbuild\lxml>call "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\VCVARSALL.bat" x86 
Setting environment for using Microsoft Visual Studio 2008 x86 tools.
Building lxml version 3.3.0.
Building without Cython.
ERROR: 'xslt-config' is not recognized as an internal or external command,
operable program or batch file.
** make sure the development packages of libxml2 and libxslt are installed **

@mgedmin
Copy link
Member

@mgedmin mgedmin commented on 68266f6 Feb 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's very confusing :-(

The Windows build procedure doesn't use xslt-config.

I'm probably explaining this to the person who wrote the code to implement that procedure ;)

@agroszer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But lxml's script uses it.... and outputs that errors. That's confusing.

Please sign in to comment.