Template variables overridden by helper

[mendezcode]

Hello @zordius

I just noticed the following: If I have a {{term_link}} helper and I also pass term_link in the template named arguments, the value is overridden by the helper.

I consider the variable should be prioritized instead of the helper as long as it is a named argument.

What do you think?

[zordius]

1. Now the priority of tags parsing in lightncandy is compileSection -> compileCustomHelper -> compileVariable . (check the code from line 1232 ~ line 1246) , so these are true now:
   • You can not overwrite build-in helpers by custom helpers, ex: {{#each }}
   • When you use duplicate names on both custom helper and variable , custom helper will be used.
2. The priority of tags parsing can be changed if we think another way is better.
3. I think lightncandy should align with handlebars.js behavior. So, I need to write some tests on handlebars.js, then decide the correct order by the testing results.

[mendezcode]

Yes, it does make sense. Behavior should be aligned with handlebars.js, completely agree.

Variables can be accessed using @root.variable, so I think it can be left as-is, now that I think of it.

[zordius]

Based on this test : http://jsfiddle.net/TY8cJ/1/

custom helper > default helper > variable

This behavior will be applied to lightncandy later.

[zordius]

After I review the code of lightncandy deeply , the current order is

compileBlockCustomHelper > compileBlockBegin > compileCustomHelper > compileVariable

So the behavior already same with handlebars.js . No more fix required, and close this. Thanks.