Bugfix fix screenboard #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teraken0509
force-pushed
the
bugfix/fix-screenboard
branch
from
643a7df
to
2a11dc6
Compare
teraken0509
force-pushed
the
bugfix/fix-screenboard
branch
from
2a11dc6
to
291e198
Compare
|
Thank you for fixing that, and derp on the X/Y thing. Nice. |
|
@zorkian
|
This was referenced Nov 13, 2018
masterzen
pushed a commit
to masterzen/go-datadog-api
that referenced
this pull request
Nov 16, 2018
Datadog API for screenboards width and height can return either numbers , number (like “1024”) strings or even strings (like “100%”). The recent fix zorkian#190 changed those fields to be only ints, breaking the compatibility with some datadog screen boards. As suggested in zorkian#192 this change fixes the issue by making the fields become `json.Number` which should cover all possible returned values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://github.com/terraform-providers/terraform-provider-datadog/issues/105
some screenboard fields are invalid from api response
Widthstring->intHeightstring->intScreen Widget json map is invalid
xandyare reversed