Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Else in activity diagram #12

Open
ZoroarkDarkrai opened this issue Nov 13, 2020 · 1 comment
Open

Else in activity diagram #12

ZoroarkDarkrai opened this issue Nov 13, 2020 · 1 comment

Comments

@ZoroarkDarkrai
Copy link
Owner

Screenshot from 2020-11-13 17-28-44.png

One of the brackets should be [else].

@nus-se-bot
Copy link

nus-se-bot commented Nov 18, 2020

Team's Response

Hi, for activity diagrams, not all guard conditions need to use "else", for example, this valid activity diagram given in the CS2103T textbook:

image.png

you can see that there are multiple instances where the guard condition did not use "else":

image.png

image.png

image.png

image.png
,
despite else being a correct usage, not using else is valid too as long as both conditions are mutually exclusive. Here, user choose dark vs user choose light is always mutually exclusive as user will never get to choose both dark and light mode at the same time. Hence, not using else is suitable in this scenario too.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Low]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants