Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass "horizontal_field_offset_class" to child renderers #391

Closed
wants to merge 3 commits into from

Conversation

vmullagaliyev
Copy link
Contributor

The "horizontal_field_offset_class" doesnt pass to child renderers (from form to fields), so it actually does't work as described in documentation.

The "horizontal_field_offset_class" doesnt pass to child renderers (from form to fields), so it actually does't work as described in documentation.
@coveralls
Copy link

coveralls commented Nov 22, 2022

Pull Request Test Coverage Report for Build 3516406101

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 97.489%

Totals Coverage Status
Change from base Build 3512541512: 0.07%
Covered Lines: 618
Relevant Lines: 630

💛 - Coveralls

@dyve
Copy link
Member

dyve commented Nov 22, 2022

Could you add a regression test?

@dyve
Copy link
Member

dyve commented Nov 22, 2022

Good catch btw 👍

@paulocoutinhox
Copy link

merge pls

@dyve
Copy link
Member

dyve commented Apr 2, 2023

This change is still missing a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants