Fix misplaced static()

[mbourqui]

The static() method is called at the wrong place, needs to have the full page to the file or it will crash.
Learnt it the hard way...

[coveralls]

Coverage remained the same at 98.198% when pulling d3e75fe on mbourqui:fix/static into 2a8bd08 on zostera:master.

[jieter]

@mbourqui Thanks for the pull.

Can you explain in what circumstances this crash occurs and what the stack trace is?

[mbourqui]

Hi @jieter,

Thanks for reaching back. It's been a while, but as far as I remember, the issue was that static() will simply prepend the static root path to the path provided, thus it will be incorrect. And on production the files will not be found, as the generated static path does not match the actual path of the file in the file system.

[jieter]

Since we don't use this feature ourselves, it is critical that will get covered by a test which checks if it shows the desires behavior. It shouldn't be too hard to add such a test, are you maybe able to do that?

[mbourqui]

There are actually already some tests here: https://github.com/zostera/django-icons/blob/master/tests/test_image.py
Or would you like some more tests specific to the get_path() function?

[jieter]

It's always nice to have a test exposing the crash along with the fix. Can we mimic the production situation in the tests, for example by using override_settings

[mbourqui]

I will update the tests, but I need some more time.

[jieter]

Great!

[mbourqui]

Took me some time, but finally here are some more specific tests!

[jieter]

Looks good to me, @dyve?

[dyve]

Nice! Thanks @mbourqui!