Create unit tests for fullness #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are not implemented in this branch. this is based off of them theoretically being in our codebase. Co-authored-by: Lily Johnson <41386414+lilyjohnson@users.noreply.github.com>
… class Co-authored-by: Lily Johnson <41386414+lilyjohnson@users.noreply.github.com>
aahsue
requested review from
lilyjohnson,
patrickanguyen,
sagarbpatel31,
dskin344 and
limenilbuz
patrickanguyen
requested changes
May 17, 2022
Comment on lines
6
to
9
| void test_can_construct_mock_distance_sensor() | ||
| { | ||
| Fullness::MockDistance mockDistanceSensor({3, -6, 27, 114, 9}); | ||
| } |
| void test_returns_correct_fullness() | ||
| { | ||
| uint32_t binHeight = 10; | ||
| int32_t calculatedAverageDistance = 5; // should be 5.5 |
There was a problem hiding this comment.
this should be a float
| Fullness::MockDistance mockDistanceSensor(distances); | ||
|
|
||
| Fullness::FullnessMetric mockFullness(binHeight, mockDistanceSensor); | ||
| TEST_ASSERT_EQUAL_INT(calculatedAverageDistance, (mockFullness.getFullness())); |
There was a problem hiding this comment.
getFullness() returns a float
Comment on lines
42
to
43
| uint32_t binHeight = 10; | ||
| int32_t calculatedAverageDistance = 5; // should be 5.5 |
|
lgtm |
patrickanguyen
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created unit tests using the Mock Distance Sensor and the Fullness Class. Checked if mock distance sensor can be constructed, that it returns the correct distance, that it can loop through the distances, and that the Fullness class returns the correct fullness and if it can recognize if a distance is valid.
Type of change
Testing and Verification Instructions
Checklist: