Rate limiting updates #141
Conversation
abaevbog
commented
Jun 5, 2023
•
abaevbog
commented
- Using $this->end() instead of exit in controllers. It ensures that concurrency rate limiter counts requests as finished.
- Make client wait for full capacity once rate limit is reached.
abaevbog
changed the title
|
So, getting rid of |
controllers/MappingsController.php
Outdated
| @@ -34,7 +34,9 @@ public function mappings() { | |||
| $locale = !empty($_GET['locale']) | |||
| ? \Zotero\Schema::resolveLocale($_GET['locale']) | |||
| : 'en-US'; | |||
|
|
|||
| unset($this->queryParams['format']); | |||
| header("Content-Type: application/json"); | |||
There was a problem hiding this comment.
Are these lines necessary? format defaults to JSON, so I would think that outputContentType() in end() would get it right. I think we were only calling header() because we weren't using end().
There was a problem hiding this comment.
Yes, these 2 lines can actually be removed.
The same 2 lines in the newItem function are still needed to get the right application/json content type for API v2
controllers/MappingsController.php
Outdated
|
|
||
|
|
||
| unset($this->queryParams['format']); | ||
| header("Content-Type: application/json"); |
There was a problem hiding this comment.
Can we just set 'json' as the default format for the mappings actions for v1/v2 in API.inc.php?
There was a problem hiding this comment.
Right. That is definitely cleaner
