Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support image extraction for image annotations for EPUBs/snapshots #4032

Open
dstillman opened this issue Apr 22, 2024 · 1 comment · May be fixed by zotero/reader#111
Open

Support image extraction for image annotations for EPUBs/snapshots #4032

dstillman opened this issue Apr 22, 2024 · 1 comment · May be fixed by zotero/reader#111
Assignees
@AbeJellinek
Labels
Enhancement Reader

Comments

@dstillman
Copy link
Member

https://forums.zotero.org/discussion/113883/add-select-area-for-snapshot-viewer

I couldn't find an issue for this, but I think we talked about supporting some version of Select Area for EPUBs/snapshots based on DOM elements. Maybe limited to single images, and you'd get a tool that highlighted them on hover and you could click to select them?
@AbeJellinek
Copy link
Member

There's an existing WIP PR for this: zotero/reader#111. I'll rebase it. As I mentioned in the PR description, it feels awkward to have this limited, single-use tool just for image extraction when the very similar Note tool already exists. What if we made the Note tool extract images instead of adding a new tool?

@AbeJellinek AbeJellinek linked a pull request May 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbeJellinek AbeJellinek

Labels
Enhancement Reader
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EPUB/snapshot image annotations zotero/reader
2 participants
@dstillman @AbeJellinek