Add test cases as possible urls in browse tab #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moreover, the browser url will stay now also when a new translator is opened and thereby all items in the menulist are removed.
zuphilip
changed the title
dstillman
reviewed
Mar 12, 2018
| //Show URL of active tab | ||
| document.querySelectorAll("textbox.browser-url").forEach(elem => elem.value = doc.location.href); | ||
| // Show URL of active tab | ||
| document.querySelectorAll("menulist.browser-url").forEach(elem => elem.value = doc.location.href); |
There was a problem hiding this comment.
Why is this a querySelectorAll(), anyway? Isn't that just because we used to have more than one of the URL bar? If there's only one now, this could just be document.getElementById('browser-url').value = … (after moving browser-url to the id).
As a consequence of 7de0e6f
|
Good comment! Please have a look at the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #77.