Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM -- Issue with proxy insertion #1449

Closed
adam3smith opened this issue Oct 19, 2017 · 0 comments
Closed

ACM -- Issue with proxy insertion #1449

adam3smith opened this issue Oct 19, 2017 · 0 comments

Comments

@adam3smith
Copy link
Collaborator

the problem is that we're not using the url the bibtex is generated from from the translator in scrape, but instead grab it from the page, where it already appears proxified (and the re-proxify it). See https://github.com/zotero/translators/blob/master/ACM Digital Library.js#L83

Reported: https://forums.zotero.org/discussion/68208/acm-digital-library-translator-broken-with-proxy#latest

Example: https://dl.acm.org/citation.cfm?id=2485927 (though this is almost certainly a general issue and will affect many/all hyphenated proxies.

adam3smith added a commit to adam3smith/translators that referenced this issue Oct 29, 2017
Closes zotero#1449
We grab URLs of the page, but they default to http version there, which
causes all sorts of havoc for https version with hyphenated
proxy. Solving this simply by deproxifying standard pattern.
adam3smith added a commit that referenced this issue Nov 7, 2017
Closes #1449
We grab URLs of the page, but they default to http version there, which
causes all sorts of havoc for https version with hyphenated
proxy. Solving this simply by deproxifying standard pattern.
jonschz pushed a commit to jonschz/translators that referenced this issue Feb 8, 2018
Closes zotero#1449
We grab URLs of the page, but they default to http version there, which
causes all sorts of havoc for https version with hyphenated
proxy. Solving this simply by deproxifying standard pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant