Adaptation Bibliotheque nationale de France.js for the new BnF catalog #1051

facem · 2016-04-15T10:41:31Z

The changes consist on :
the Import works whatever display style (intermarc, unimarc, public)
in the field 'URL' there is a ARK link of the notice
the URL of numeric document is in field "attachement document"
correction for the role detection
The document type detection uses the field Unimarc
Modification of the field "source"

adam3smith · 2016-04-22T14:32:34Z

Bibliotheque nationale de France.js

@@ -41,7 +41,8 @@ var BnfClass = function() {
 		See http://archive.ifla.org/VI/3/p1996-1/appx-c.htm.
 	*/
 	function getCreatorType(aut) {
-		switch(aut['4']) {
+		typeAut = aut['4'].replace(/\s/g,"");


should be var typeAut and I'd use .trim() instead of the replace.

adam3smith · 2016-04-22T14:41:36Z

@symac -- if you have a minute to look over this? Makes a lot of sense to me, but you wrote most of the code.

Suppressions method getDCType and translateDCType. These methods don't work with any display.

facem · 2016-04-22T16:15:26Z

Hello,
I have corrected.
I have deleted the method that didn't work with all display.
I hadn't made before because I did not want to change too much the code

facem · 2016-05-03T06:59:18Z

Hello,
I have corrected and simplidied the code.
I have deleted the method that didn't work with all display.
I hadn't made before because I did not want to change too much the code

Best regard

2016-04-22 16:41 GMT+02:00 Sebastian Karcher notifications@github.com:

@symac https://github.com/symac -- if you have a minute to look over
this? Makes a lot of sense to me, but you wrote most of the code.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1051 (comment)

adam3smith · 2016-05-05T04:10:01Z

Bibliotheque nationale de France.js

@@ -41,7 +41,9 @@ var BnfClass = function() {
 		See http://archive.ifla.org/VI/3/p1996-1/appx-c.htm.
 	*/
 	function getCreatorType(aut) {
-		switch(aut['4']) {
+		//typeAut = aut['4'].replace(/\s/g,"");
+		typeAut = aut['4'].trim();


you're still not declaring the variable here. Needs to be var typeAut = ...

adam3smith · 2016-05-05T04:11:59Z

Looks good to me otherwise.

facem · 2016-05-09T06:49:03Z

Hello
I'm sorry for this mistake.
I have just corrected.
Thank you for the time that you spend for me and for your help
Best regard

symac · 2016-05-09T12:35:02Z

Trying the new translator I have encountered an error when trying to get list (but I believe they also exist in the previous version, seems BnF has updated their markup). In getSelectedItems function, there is the following line :
var link = doc.evaluate('./div[@class="notice-contenu"]/a', cell, null, XPathResult.ANY_TYPE, null).iterateNext();

that needs to be replaced by :
var link = doc.evaluate('./div[@class="notice-contenu"]/div[@class="notice-synthese"]/a', cell, null, XPathResult.ANY_TYPE, null).iterateNext();

The div with the class notice-synthese has been added meanwhile I believe. Otherwise I have not found any error with some tests, seems ok to me.

don't do anything when the page type is undefined

facem · 2016-05-10T07:22:38Z

Hello
Indeed, I have just corrected and I have change the code for don't do nothing when the page type is "undefined".

Best regard

facem · 2016-05-19T07:11:53Z

Hello,

I corrected the last error.

Is it good?

what happens when it is ok ?

Best regard

Le 9 mai 2016 14:35, "Sylvain Machefert" notifications@github.com a
écrit :

Trying the new translator I have encountered an error when trying to get
list (but I believe they also exist in the previous version, seems BnF has
updated their markup). In getSelectedItems function, there is the following
line :
var link = doc.evaluate('./div[@Class="notice-contenu"]/a', cell, null,
XPathResult.ANY_TYPE, null).iterateNext();

that needs to be replaced by :
var link =
doc.evaluate('./div[@Class="notice-contenu"]/div[@Class="notice-synthese"]/a',
cell, null, XPathResult.ANY_TYPE, null).iterateNext();

The div with the class notice-synthese has been added meanwhile I
believe. Otherwise I have not found any error with some tests, seems ok to
me.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
Le 9 mai 2016 14:35, "Sylvain Machefert" notifications@github.com a
écrit :

Trying the new translator I have encountered an error when trying to get
list (but I believe they also exist in the previous version, seems BnF has
updated their markup). In getSelectedItems function, there is the following
line :
var link = doc.evaluate('./div[@Class="notice-contenu"]/a', cell, null,
XPathResult.ANY_TYPE, null).iterateNext();

that needs to be replaced by :
var link =
doc.evaluate('./div[@Class="notice-contenu"]/div[@Class="notice-synthese"]/a',
cell, null, XPathResult.ANY_TYPE, null).iterateNext();

The div with the class notice-synthese has been added meanwhile I
believe. Otherwise I have not found any error with some tests, seems ok to
me.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

adam3smith · 2016-05-19T13:26:54Z

thanks!

facem · 2016-05-20T06:33:58Z

Hello
Great
Thanks for all.
Best reagard

2016-05-19 15:26 GMT+02:00 Sebastian Karcher notifications@github.com:

thanks!

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1051 (comment)

zotero#1051) * adaptation for a new markup for the list. * don't do anything when the page type is undefined

Adaptation Bibliotheque nationale de France.js for the new BnF catalog

0769cc8

adam3smith reviewed Apr 22, 2016
View reviewed changes

Corrections for replace to Trim in the method getCreatorType

d7a7861

Suppressions method getDCType and translateDCType. These methods don't work with any display.

adam3smith reviewed May 5, 2016
View reviewed changes

Correction for declaring variable typeAut

032abfb

adaptation for a new markup for the list.

2bbcaeb

don't do anything when the page type is undefined

adam3smith merged commit ef385aa into zotero:master May 19, 2016

zuphilip mentioned this pull request Jan 1, 2017

Modification Bibliotheque nationale de France.js #1195

Merged

zuphilip pushed a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Adaptation Bibliotheque nationale de France.js for the new BnF catalog (

86f5918

zotero#1051) * adaptation for a new markup for the list. * don't do anything when the page type is undefined

zuphilip pushed a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Adaptation Bibliotheque nationale de France.js for the new BnF catalog (

3bf7e73

zotero#1051) * adaptation for a new markup for the list. * don't do anything when the page type is undefined

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adaptation Bibliotheque nationale de France.js for the new BnF catalog #1051

Adaptation Bibliotheque nationale de France.js for the new BnF catalog #1051

facem commented Apr 15, 2016

adam3smith Apr 22, 2016

adam3smith commented Apr 22, 2016

facem commented Apr 22, 2016

facem commented May 3, 2016

adam3smith May 5, 2016

adam3smith commented May 5, 2016

facem commented May 9, 2016

symac commented May 9, 2016

facem commented May 10, 2016

facem commented May 19, 2016

adam3smith commented May 19, 2016

facem commented May 20, 2016

Adaptation Bibliotheque nationale de France.js for the new BnF catalog #1051

Adaptation Bibliotheque nationale de France.js for the new BnF catalog #1051

Conversation

facem commented Apr 15, 2016

adam3smith Apr 22, 2016

Choose a reason for hiding this comment

adam3smith commented Apr 22, 2016

facem commented Apr 22, 2016

facem commented May 3, 2016

adam3smith May 5, 2016

Choose a reason for hiding this comment

adam3smith commented May 5, 2016

facem commented May 9, 2016

symac commented May 9, 2016

facem commented May 10, 2016

facem commented May 19, 2016

adam3smith commented May 19, 2016

facem commented May 20, 2016