Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change version to versionNumber for computerProgram" #1085

Merged
merged 10 commits into from Jun 21, 2016

Conversation

adam3smith
Copy link
Collaborator

Reverts #1084

@adam3smith adam3smith merged commit 971861c into master Jun 21, 2016
@zuphilip
Copy link
Contributor

Hm.. I see that there is a problem in Ubuntu but in Windows it seems to work. I tried the CSV translator with "minVersion": "4.0.27", but it works with "minVersion": "4.0.26", and every smaller number. The error message seems quite clear:

(2)(+0000001): Translate: Translation using CSV failed: 
string => TypeError: item.uniqueFields is undefined
stack => getValue@CSV:211:1
doExport@CSV:110:7

@dstillman Any ideas what is going on? Was there any change for uniqueFields in this version?

@dstillman
Copy link
Member

I don't really know anything about the uniqueFields stuff, sorry.

@aurimasv
Copy link
Contributor

There are no uniqueFields in the API version of Zotero.Item JSON. https://github.com/zotero/zotero/blob/master/test/tests/data/translatorExport.js

@zuphilip
Copy link
Contributor

Is uniqueFields old code and only supported for legacy translators (pre 4.0.27) via addCompatibilityMappings?

Please let me know whether it is true that: By increasing the minVersion to 4.0.27 the function addCompatibilityMappings will not be called. This could explain the problems with the translators commit...

@aurimasv
Copy link
Contributor

Please let me know whether it is true that: By increasing the minVersion to 4.0.27 the function addCompatibilityMappings will not be called

That is correct.

zuphilip pushed a commit to zuphilip/translators that referenced this pull request Mar 28, 2018
…1085)

We get too many error reports -- I don't know why, but let's revert first, then try to figure this out. CC@zuphilip
zuphilip pushed a commit to zuphilip/translators that referenced this pull request Mar 28, 2018
…1085)

We get too many error reports -- I don't know why, but let's revert first, then try to figure this out. CC@zuphilip
@adam3smith adam3smith deleted the revert-1084-versionnumber branch May 20, 2019 14:29
@zuphilip zuphilip mentioned this pull request Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants