Enable 5 translators for translation-server + Google-Books-ID #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable JSTOR, Primo, ScienceDirect, Wiley Online, and Google Books translators. Add regex for 12 character google books ID, and add url to citation based on that ID. Change-Id: I706250304fb8df4e53ee45c3e32ced7970e7f19e
|
Great, thanks both! |
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
…#1100) Enable JSTOR, Primo, ScienceDirect, Wiley Online, and Google Books translators. Add regex for 12 character google books ID, and add url to citation based on that ID. * [Google Books.js] Use extra field for Google-Books-ID
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Mar 28, 2018
…#1100) Enable JSTOR, Primo, ScienceDirect, Wiley Online, and Google Books translators. Add regex for 12 character google books ID, and add url to citation based on that ID. * [Google Books.js] Use extra field for Google-Books-ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR superseeds #1097 and #1066 from @mvolz (CC @owcz) and fixes also the multiples in Google Books translator and updates the test cases.
Note the other four translators have the same
lastUpdate-date, such that this difference is not pushed to all Zotero users immediatly. However, it only makes a difference for the translation-server.