Fix authors and publication titles in EM #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For proceedings titles, https://scholarworks.umass.edu/climate_nuclearpower/2011/nov19/34/ imported og:site_title as proceedings title; Test case for authors is https://ui.adsabs.harvard.edu/#abs/1995A&A...303..497V which doesn't work as automated test w/o defer The WHO site has changed, we now have a dedicated translator, so removign test that no longer works
|
@zuphilip let me know if you're going to be able to review this soon. No problem if not, but I'd then merge this and the others under review, as they all repair broken stuff. |
|
This looks fine and I think I have encountered the problems with the wrong authors splitting in EM before, but can't remember. Thank you @adam3smith! I try to look at some of the other PR now, but can't promise anything... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For proceedings titles, https://scholarworks.umass.edu/climate_nuclearpower/2011/nov19/34/
imported og:site_title as proceedings title; Test case for authors is
https://ui.adsabs.harvard.edu/#abs/1995A&A...303..497V which doesn't work as automated test w/o defer
The WHO site has changed, we now have a dedicated translator, so removign test that no longer works