Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translator Landesbibliographie Baden-Wurttemberg.js #1774

Merged
merged 4 commits into from Nov 4, 2018

Conversation

zuphilip
Copy link
Contributor

@zuphilip zuphilip commented Nov 1, 2018

No description provided.

Copy link
Collaborator

@adam3smith adam3smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions&requests, looks good otherwise. Thanks!

"items": [
{
"itemType": "journalArticle",
"title": "Überfordert : Mozart: Don Giovanni : Mannheim, Nationaltheater",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove spaces before colons in titles and update tests?

"fieldMode": 1
}
],
"date": "2000///(2001); 2001/02(2003) -",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clean this? I'm not even sure how Zotero would end up parsing this date (though I think just as 2000?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is more complicated because here the whole series is meant. So

Erscheinungsverlauf: | 1972/73 - 1999/2000(2001); 2001/02(2003) -

means that there was a report for 1972/1973, ..., and another report for 1999/2000 published in 2001, but no report in 2000/2001 (the note explained why). Then from 2001/2002 in 2003 it started again normally.

How about moving the date in this case to a note? Deleting would be okay also for me, because these report (series) are not my main focus here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still pick a date to import, maybe the first one? Putting the rest into notes sounds right.

"title": "Rechenschaftsbericht ... des Rektors",
"creators": [
{
"lastName": "Universität ",
Copy link
Collaborator

@adam3smith adam3smith Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as <Mannheim> in the RIS export and then apparently ignored by Zotero. I'm suspecting because that was your search term? I think it's save to just clean pointy brackets from the RIS completely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from

AU  - Universität <Mannheim>

which is catalogued as a "Körperschaft" in the original. Maybe we could move it to a contributor but I don't know how to identifies these cases. Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had seen that but markdown swallowed the relevant bit. I think we should leave it as author, which seems fine to me, but we should filter out the pointy brackets (< >) so that it actually imports as "Universität Mannheim" and not just "Universität "

@zuphilip
Copy link
Contributor Author

zuphilip commented Nov 1, 2018

Please have a look at the new version.

@zuphilip zuphilip added the New Translator Pull requests for new translators label Nov 1, 2018
@adam3smith adam3smith merged commit 8f64313 into zotero:master Nov 4, 2018
@adam3smith
Copy link
Collaborator

Great, thanks!

@zuphilip zuphilip deleted the labi-bw branch November 4, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Translator Pull requests for new translators
Development

Successfully merging this pull request may close these issues.

None yet

2 participants