BBC language fix #1833
Closed
BBC language fix #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @leoncastro for the try, but that does not work and is not valid JS. Anyway, I see the issue and can fix it, which might be easier. |
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Jun 10, 2019
This superseeds zotero#1833.
|
My bad. Replace "or" with "||" and you will get an easier, working and valid JS. |
|
Superseeded by #1956. |
zuphilip
added a commit
to zuphilip/translators
that referenced
this pull request
Jun 15, 2019
This superseeds zotero#1833.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language code
en-GBfor the BBC must not be fixed (as done here), because it uses different languages (examples: fr, es, pt, ru, ...). Language can be found in the HTMLlangtag, using the preset only as fallback.Maybe it works if you replace that line with:
item.language = ZU.xpathText(doc, '//*/@lang/') or "en-GB";