New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bioconductor translator #1983
Conversation
I have no idea about the error. Could anyone help to check? Thanks! @zuphilip |
This are "only" linting issues which can also be fixed later. It is not an error per se. However, try to change the line Line 84 in 229f4aa
into simply |
@zuphilip Thank you! Finally, all checks have passed. Hope it can be accepted soon :) |
Great! I can't promise to review it fast... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! The code already looks quite good and most things are stable even while the website itself does not have much structure to extract the information from. There are some issues to fix and improve, see my review, but everything should be doable. Let us when you are through, then we can check it again and merge it.
…h Bioc version number; Add 'and' to split authors; Change creator type to 'programmer'; Update date to the release year; Add an old relase case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine in general, but there are some small issues to fix. Please ping me again if you are through.
Merged now! 🚀 Thank you very much @hubentu for all the work! |
The search page ("multiple") worked manually but failed in the testing. Could anyone help to debug? Thanks!