Fix and improve BibTeX parsing #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In some cases the rawValue was undefined which caused a problem in the author field. - Handle electronic as webpage - Skip preamble - Improve inline documentation
zuphilip
commented
Oct 13, 2019
There was a problem hiding this comment.
I tested this with the long bibtex test file from https://github.com/citation-js/bibtex-parser-experiments/blob/master/test/files/long.bib and everything worked well. Now, we are importing all 3345 entries and not other side effect was detected during the import. I will merge this the next days, if no one objects.
Moreover, allow special characters like colon or underscore to be part of the string name.
zuphilip
force-pushed
the
bibtex-edge-cases
branch
from
a99aac4
to
1d7bc03
Compare
zuphilip
added
the
Improvements
|
This looks good to me, but leaving for you to merge, not having read the code closely enough. |
This was referenced Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a problem in the author field.