Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean BibTeX citekey more rigorously in the future #2072

Merged
merged 1 commit into from Dec 10, 2019
Merged

Clean BibTeX citekey more rigorously in the future #2072

merged 1 commit into from Dec 10, 2019

Conversation

zuphilip
Copy link
Contributor

This superseeds #1013.

@zuphilip zuphilip changed the title Clean BibTeX citekey more rigourosly in the future Clean BibTeX citekey more rigorously in the future Nov 30, 2019
@adam3smith
Copy link
Collaborator

oh, that's clever, I like this solution.
Would you be up for also linting the translator or is that totally gruesome? If not, OK to merge from my end.

@zuphilip
Copy link
Contributor Author

zuphilip commented Dec 9, 2019

I don't want to fix linting issues as long as there are other open PR for BibTeX translator, e.g. #1937, #1073, #2028 (also that is more there as an issue). Okay?

@adam3smith adam3smith merged commit af62f3a into zotero:master Dec 10, 2019
@zuphilip zuphilip deleted the bibtex-citekey branch December 10, 2019 16:48
zuphilip added a commit to zuphilip/translators that referenced this pull request Dec 15, 2019
@zuphilip
Clean BibTeX citekey more rigorously in the future
0f5bff5 
These are the same lines as for the BibTeX translator in zotero#2072.
@zuphilip zuphilip mentioned this pull request Dec 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam3smith adam3smith Awaiting requested review from adam3smith

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zuphilip @adam3smith