New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translator for Library Hub Discover search results #2082
Conversation
I think we'll actually want to check if we can do better than COinS (which is a very limited format). I suspect we can, e.g. using the provided MODS |
Do you have some kind of reference on the hierarchy between formats? This would be useful |
Not a reference but broadly:
Should work exactly the same, yes. |
I tried to implement it using the MODS endpoints but this is really not satisfactory, because the type is rarely well detected. Eg this item which is obviously a feature film, is detected by MODS as a "video recording", COinS thinks everything is a book and RIS find the right "film" type, but I did not find any unambiguous element on the page to detect the right type (the schema information is "CreativeWork" and the Library Hub info is "visual", which is shared with a lot of categories). |
Thanks! Sorry for the delay in getting this merged. |
Fix #1986. This is really just a wrapper for COinS on the search results (I'm not sure how useful this is or if it is good practice to make such a limited translator - does it slow the connector's loading?). In any case I added https://discover.libraryhub.jisc.ac.uk/search?q=test as a test and it works fine, COins works seamlessly on individual items (NB: this was noted on the original issue https://forums.zotero.org/discussion/78478/library-hub-discover-replacing-copac-is-there-a-zotero-translator#latest)