Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Financial Times: Remove FW, update for current site #2384

Merged
merged 4 commits into from
May 28, 2021

Conversation

AbeJellinek
Copy link
Member

@AbeJellinek AbeJellinek commented May 25, 2021

The search test will fail on CI. Fixes #1391, fixes #1075.

Financial Times.js Outdated Show resolved Hide resolved
Financial Times.js Outdated Show resolved Hide resolved
Financial Times.js Outdated Show resolved Hide resolved
Financial Times.js Outdated Show resolved Hide resolved
Financial Times.js Outdated Show resolved Hide resolved
We're probably still not going to get this if we're paywalled, because
it comes from the behind-paywall HTML, but it works well when running in
the browser (and section isn't the most important field).

(defer: true won't change anything here because CI doesn't have access.)
@dstillman
Copy link
Member

Looks good. (Not sure we've ever used AMP for anything before. I guess we'll see how stable it is.)

@AbeJellinek AbeJellinek merged commit 809e397 into zotero:master May 28, 2021
@AbeJellinek AbeJellinek deleted the ft branch May 28, 2021 18:15
@AbeJellinek
Copy link
Member Author

Meant to squash, but oh well. Next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Financial Times broken after redesign Financial Times translator issues
2 participants