Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Translator: New Left Review #2453

Merged
merged 5 commits into from Jun 16, 2021
Merged

New Translator: New Left Review #2453

merged 5 commits into from Jun 16, 2021

Conversation

boan-anbo
Copy link
Contributor

Copy link
Member

@AbeJellinek AbeJellinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks really good. Left a few comments.

New Left Review.js Outdated Show resolved Hide resolved
New Left Review.js Show resolved Hide resolved
New Left Review.js Outdated Show resolved Hide resolved
New Left Review.js Outdated Show resolved Hide resolved
New Left Review.js Outdated Show resolved Hide resolved
2. corrected abbreviation.
3. use Zu.cleanAuthor() for author names.
New Left Review.js Outdated Show resolved Hide resolved
2. retested under both paywalled and unpaywalled conditions. The PDF are downloded under unpaywalled condition. The tests refelect paywalled condition.
2. retested under both paywalled and unpaywalled conditions. The PDF are downloded under unpaywalled condition. The tests refelect paywalled condition.
@AbeJellinek
Copy link
Member

OK, this is pretty much ready. Add the paywalled PDF attachments back to the tests and I'll merge it in.

@AbeJellinek AbeJellinek merged commit d70332d into zotero:master Jun 16, 2021
@AbeJellinek
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants