Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't detect J-Stage PDFs #3030

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

adam3smith
Copy link
Collaborator

https://forums.zotero.org/discussion/104661/cannot-download-papers-from-jstage#latest

@dstillman @AbeJellinek -- there's a larger question here about how much effort we should make to actually detect & translate on PDF pages. Here, it's easy to a) detect this is JSTAGE and b) construct the article landing page from the PDF page, so doing a proper translation would require construction that and a processDocument call -- is that worth it or not (FWIW, recognize PDF doesn't work super reliably for JSTAGE PDFs because they have wonky encoding issues)?

@dstillman
Copy link
Member

I've been thinking about this lately, and I think a general goal for the project needs to be to reduce the number of places where people can do the "wrong" thing. No matter how many times we say that you should save this or that way, people are going to do what they do, so we should aim to make it not matter as much as possible. (There are various other contexts where this applies.)

So, if a translator would detect and break regular PDF saving, like here, we should obviously fix that.

If metadata retrieval doesn't work well and we can do the save, we should do it, so that we don't have to tell people they're doing something wrong when they click the save button on the PDF.

If metadata retrieval works well, though, I think it's fine to rely on that. (Metadata updating should also be able to help fill in abstracts or other things that might be missed.)

@dstillman dstillman merged commit 402c668 into zotero:master Apr 28, 2023
@adam3smith adam3smith deleted the j-stage-detect branch May 4, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants