Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Câmara Brasileira do Livro ISBN search #3091

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

AbeJellinek
Copy link
Member

I made it priority 98 like BnF and National Library of Poland - like those translators, it filters based on the ISBN prefix, and their API is very fast and returns authoritative (if not always perfectly clean) data.

Closes #3086

@RENANZG
Copy link

RENANZG commented Aug 2, 2023

ALL WORKIN, I LOVE YOU !
978-65-5956-965-6
978-65-995947-5-5
978-85-422-1759-9
978-65-88299-88-3
978-85-85257-32-3
978-65-88299-92-0
I was doing everything wrong, until I read the site (oh, noobs):
https://www.zotero.org/support/dev/translators

WILL THIS CHANGE GO TO THE DEFINITIVE VERSION OF ZOTERO LATER?

I was thinking, we need Brazilian magazines too. They have the ISSN code.

This is the query portal:
https://portal.issn.org/

Some codes:
ISSN 2763-7867
ISSN 2177-8116
ISSN 2763-5244
ISSN 2236-1677

We will need to make a statue of AbeJellinek at our university after this.

@zoe-translates
Copy link
Collaborator

Hi @RENANZG just an aside: The ISSN identifies a serial, so it can't be used to identify one single publication. In other words you can't import or cite by ISSN. The ISSN value can only become part of the metadata attached to a citable item, such as an article in a specific issue of the serial.

Copy link
Collaborator

@adam3smith adam3smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts where we might add some metadata tweaks, but looks great in general

Camara Brasileira do Livro ISBN.js Show resolved Hide resolved
Camara Brasileira do Livro ISBN.js Show resolved Hide resolved
Camara Brasileira do Livro ISBN.js Outdated Show resolved Hide resolved
Camara Brasileira do Livro ISBN.js Show resolved Hide resolved
Camara Brasileira do Livro ISBN.js Outdated Show resolved Hide resolved
// If there's a corresponding entry in the Profissoes array, use it
if (result.Profissoes.length > i) {
switch (result.Profissoes[i]) {
case 'Coordenador':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to flag that "Coordenador" is a tricky term and I've seen it used as both editor (in the sense of convener) and author. Probably nothing much we can do about that, though.

@RENANZG
Copy link

RENANZG commented Aug 25, 2023

Please put it in the repository for download. Thanks

@AbeJellinek
Copy link
Member Author

Alright, I'm going to merge this with the very conservative author handling because I haven't been able to find any way to get better author metadata. Too bad.

@AbeJellinek AbeJellinek merged commit 42e14d3 into zotero:master Sep 15, 2023
1 check failed
@AbeJellinek AbeJellinek deleted the camara-brasileira branch September 15, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ISBN for Brazilian researchers
5 participants