Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect snapshot preference #319

Closed
wants to merge 4 commits into from
Closed

Respect snapshot preference #319

wants to merge 4 commits into from

Conversation

aurimasv
Copy link
Contributor

Highwire and EM

@simonster
Copy link
Member

I don't think this should make a difference. AFAIK we only check for attachment.snapshot === false.

@aurimasv
Copy link
Contributor Author

It seems to matter. At least from my testing. Maybe it's been changed since
3.0.3
On Apr 24, 2012 9:42 PM, "Simon Kornblith" <
reply@reply.github.com>
wrote:

I don't think this should make a difference. AFAIK we only check for
attachment.snapshot === false.


Reply to this email directly or view it on GitHub:
#319 (comment)

@aurimasv
Copy link
Contributor Author

You're right, that doesn't make a difference. Though I can't get Cell Press translator to not attach snapshots for some reason. E.g. http://www.cell.com/abstract/S0092-8674%2811%2900581-2 using Zotero Firefox HEAD revision from 3.0 branch.

EDIT: There's quite a delay before snapshot is attached though

@aurimasv
Copy link
Contributor Author

I'm not sure how I was getting these snapshots before. Can't reproduce this any more.

@aurimasv aurimasv closed this May 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants