Fix for 'Condé Nast' being parsed as author in Embedded Metadata.js #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofferb
force-pushed
the
conde-nast-fix
branch
from
0988aa1
to
f2d146c
Compare
geofferb
changed the title
AbeJellinek
requested changes
Mar 27, 2024
Co-authored-by: Abe Jellinek <jellinek@berkeley.edu>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been documented at https://phabricator.wikimedia.org/T298427 and affects all websites owned by Condé Nast, as they contain the tag
<meta name="author" content="Condé Nast">.I've fixed this by adding a check for "Condé Nast" when the metadata tag is parsed, which allows the correct author to be parsed.