Adding GameStudies, Journal of Extension #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Journal of Extension (www.joe.org) to web translators.
Added GameStudies (www.gamestudies.org) to web translators.
Removed AccessDate property in testCase.
| "translatorID": "8c2c716c-09ba-421a-ae23-a1590d90a95e", | ||
| "label": "Game Studies", | ||
| "creator": "John Weis", | ||
| "target": "gamestudies\\.org", |
There was a problem hiding this comment.
could we be more restrictive here? ^https?://gamestudies\\.org/ (ending slash is also prefered since it works bettet with proxies)
|
That should be all. Let us know if anything is unclear, otherwise let us know when you've made all changes. (For future reference, we prefer one pull request per translator, though this is going to be fine). |
Cleaner extraction of Keyword (GameStudies), Abstract (JoE) sections
Snapshots added to both journals. JoE date extraction changed from .split() method to .match() regex.
Added test cases, better detect criteria for JoE
|
Please undo the renames of three unrelated translators. (did Scaffold do this?) |
| "label": "Game Studies", | ||
| "creator": "John Weis", | ||
| "target": "^https?://gamestudies\\.org/", | ||
| "minVersion": "4.0.26.4", |
There was a problem hiding this comment.
2.1.9 for current framework translators
There was a problem hiding this comment.
Changed for both translators
| }, | ||
| { | ||
| url :FW.Url(), | ||
| title :"Article Snapshot", |
Changed MinVersion to 2.1.9 because of Framework compatibility. Fixed spaces, GameStudies detection regex.
Removed
This reverts commit 58b26cd. Conflicts: Game Studies.js Journal of Extension.js
aurimasv
added a commit
that referenced
this pull request
Jul 25, 2015
Adding GameStudies, Journal of Extension
|
Thanks for working on this! I squashed your commits and merged them into master, then made a few tweaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these two journals, with testing, to web translators.