-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving from Annual Reviews doesn't finish in Safari #396
Comments
3 parts to this:
I don't think we can do much about (1). I'll address (3) once I figure out why that is. Somebody needs to say whether this makes sense for (2). @AbeJellinek ? Also it's likely reproducible on iOS. |
Why does (1) happen in Safari but not other browsers? |
BrowserExt automatically attach all available cookies to CORS bypassing HTTP requests from background pages. We only have |
(2): I think that's the correct behavior, or at least consistently the way that import translators work. They generally just don't return any items if they don't get any input. Not sure whether we have anything that relies on that, like web translators that expect a silent failure on an empty input. Failing translation on empty/invalid input could lead to more translation errors being displayed to the user, but maybe that's good? Every so often people on the forums are confused because they try to translate a site and just see an empty progress window, usually because the endpoint we use to export metadata has changed and we're just silently failing. Might be better to show an error and fall back to a more generic translator in that case. |
Similar issue reported for the DOI translator here https://forums.zotero.org/discussion/108043/report-id-582994270-safari-on-mac-connector-does-not-save-page Something in the translation chain should throw an error when a translator that detects for a page then does not save any items, either the translator itself or the translation framework @dstillman @zoe-translates |
Separate from #395, in the release version of the Safari connector, saving from the same Annual Reviews URL shows an empty save popup and never completes, as reported here:
https://forums.zotero.org/discussion/98608/bug-zotero-connector-and-annual-reviews
(That mentions Brave too, but it works fine for me in Chrome.)
Debug output for that shows it getting further but still not saving to Zotero:
The text was updated successfully, but these errors were encountered: