Generic EM translation in Zotero #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomasven
force-pushed
the
feature/generic-EM-translation
branch
2 times, most recently
from
ee60412
to
44203ab
Compare
adomasven
force-pushed
the
feature/generic-EM-translation
branch
from
44203ab
to
af28a03
Compare
|
Closes #206 |
|
(so I'd like to see, in addition to "Expose the snapshots pref in the context menu" with the "Include Snapshots" toggle, a similar toggle for "Include PDFs and Other Files") |
adomasven
force-pushed
the
feature/generic-EM-translation
branch
2 times, most recently
from
ffcafc0
to
b5d9864
Compare
Also misc browserExt code refactoring
adomasven
force-pushed
the
feature/generic-EM-translation
branch
from
b5d9864
to
4ba81db
Compare
adomasven
added a commit
to adomasven/zotero-connectors
that referenced
this pull request
Apr 5, 2018
Addresses zotero#166. Safari does not get this yet, because improved Safari popover menus are blocked by PR zotero#193.
|
Probably makes sense to move the pref for automatic tags to the connector too #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Notes:
Make EM the generic translator. Addresses #1092 translators#1434 needs to be merged at minimum, otherwise saves with EM will not work.See Make EM the generic translator. Addresses #1092 translators#1434 (comment) for explanationShould make sure that we no longer apply the snapshot and attachment pref in the client.