Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Fix failure to run non-web translators' tests in debug build. #429

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Testing: Fix failure to run non-web translators' tests in debug build. #429

wants to merge 3 commits into from

Commits on Mar 27, 2023

  1. Testing: Fix failure to run non-web translators' tests in debug build. 

    - In the testTranslators tool included in the debug build, there is an
  incorrect script path preventing the type schema data from loading.
- In cachedTypes.js, the callback passed to `getSchema()` is not called.
  (The call site is in `translatorTester_viewer.js`).

The overall effect is that non-web translators' test code did not run at
all.

This is fixed by including the correct script path, and call the
callback in `getSchema()`.
    @zoe-translates
    zoe-translates committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    734faa3 View commit details
    Browse the repository at this point in the history

  2. Testing: reinstate getSchema(), update the test-runner call site in… 

    …sted.

This partially reverts 734faa3 and
restores the call signature of `getSchema()` (with the stale comment
about it removed). Instead, fix the caller by moving the callback to a
`then()` handler after it.
    @zoe-translates
    zoe-translates committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    6c2d12c View commit details
    Browse the repository at this point in the history

  3. [Minor] Remove <script> referencing deleted file. 

    The file node_modules.js was deleted in
69627e7.
    @zoe-translates
    zoe-translates committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    1775532 View commit details
    Browse the repository at this point in the history