Update dependencies (#970)

* Update SPM dependencies * Fix warnings * Add PDFViewControllerDelegate logging
zotero · Jun 27, 2024 · 3dab779 · 3dab779
1 parent 94cbde2
commit 3dab779
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 11 deletions.
diff --git a/.swiftlint.yml b/.swiftlint.yml
@@ -170,7 +170,7 @@ ns_number_init_as_function_reference: error
 
 opening_brace:
   severity: error
-  allowMultilineFunc: true
+  allow_multiline_func: true
 
 operator_usage_whitespace:
   severity: error
@@ -213,7 +213,7 @@ return_arrow_whitespace: error
 
 self_binding:
   severity: error
-  bindIdentifier: self
+  bind_identifier: self
 
 self_in_property_initialization: error
 

diff --git a/ZShare/ViewModels/ExtensionViewModel.swift b/ZShare/ViewModels/ExtensionViewModel.swift
@@ -1183,7 +1183,7 @@ final class ExtensionViewModel {
                 guard let response = responses.first else { return .unknown }
                 return alamoErrorRequiresAbort(.responseValidationFailed(reason: .unacceptableStatusCode(code: response.code)), url: nil, libraryId: libraryId)
 
-            case .authorizationFailed(let statusCode, let response, _):
+            case .authorizationFailed(let statusCode, _, _):
                 return alamoErrorRequiresAbort(.responseValidationFailed(reason: .unacceptableStatusCode(code: statusCode)), url: nil, libraryId: libraryId)
 
             default:

diff --git a/Zotero.xcodeproj/project.pbxproj b/Zotero.xcodeproj/project.pbxproj
@@ -6561,7 +6561,7 @@
 			repositoryURL = "https://github.com/realm/realm-cocoa";
 			requirement = {
 				kind = exactVersion;
-				version = 10.51.0;
+				version = 10.52.0;
 			};
 		};
 		B35E4B8B25248B3C000EA134 /* XCRemoteSwiftPackageReference "RxSwift" */ = {
@@ -6577,7 +6577,7 @@
 			repositoryURL = "https://github.com/PSPDFKit/PSPDFKit-SP";
 			requirement = {
 				kind = exactVersion;
-				version = 13.6.0;
+				version = 13.7.0;
 			};
 		};
 		B3D84BEE27919FDE005DDD7C /* XCRemoteSwiftPackageReference "Starscream" */ = {

diff --git a/Zotero.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Zotero.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -78,8 +78,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/PSPDFKit/PSPDFKit-SP",
       "state" : {
-        "revision" : "22a0f57712dab4f8b7c196c6e02e533c225c357d",
-        "version" : "13.6.0"
+        "revision" : "fff37620437d93571e38675440da5257ff4a9fd5",
+        "version" : "13.7.0"
       }
     },
     {
@@ -96,17 +96,17 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/realm/realm-cocoa",
       "state" : {
-        "revision" : "4c4413abd0cd2221f59318f800960fe5bddc1494",
-        "version" : "10.51.0"
+        "revision" : "fb903a9c901cb7863953fdcb5182b05ca2275b27",
+        "version" : "10.52.0"
       }
     },
     {
       "identity" : "realm-core",
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/realm/realm-core.git",
       "state" : {
-        "revision" : "f3d7ae5f9f31d90b327a64536bb7801cc69fd85b",
-        "version" : "14.9.0"
+        "revision" : "058ecce712b4be8b2a2384ed893bf83d56a49fc0",
+        "version" : "14.10.1"
       }
     },
     {

diff --git a/Zotero/Scenes/Detail/PDF/Views/PDFDocumentViewController.swift b/Zotero/Scenes/Detail/PDF/Views/PDFDocumentViewController.swift
@@ -789,6 +789,12 @@ extension PDFDocumentViewController: PDFViewControllerDelegate {
     func pdfViewController(_ pdfController: PDFViewController, didSelectText text: String, with glyphs: [Glyph], at rect: CGRect, on pageView: PDFPageView) {
         parentDelegate?.didSelectText(text)
     }
+
+    func pdfViewController(_ pdfController: PDFViewController, didFinishRenderTaskFor pageView: PDFPageView, error: (any Error)?) {
+        if let error {
+            DDLogError("PDFDocumentViewController: PDFViewController didFinishRenderTaskFor \(pageView) with error - \(error)")
+        }
+    }
 }
 
 extension PDFDocumentViewController: BackForwardActionListDelegate {