Windows: support the /S switch for restricted user accounts running silent installations #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails.
Previously the Windows installer was intending to try each of the following
folders in turn until one with write access was found
Windows XP
----------
* c:\Program Files
* c:\Documents and Settings\All Users\Application Data
* c:\Documents and Settings\<current user>\Application Data
Windows 7
---------
* c:\Program Files or c:\Program Files (x86)
* c:\ProgramData
* c:\Users\<current user>\AppData\roaming
What was actually happening was that if the second path was checked for and
was found to be writable by the current user, then the 3rd option would be
chosen. If the current user did not have write access to the second path,
however, then that path would be chosen.
A user running the installer with administrative access should be able to put
programs in the first path. Should this not be the case, it would be better to
abort the installation rather than look for an alternate place to install the
software system-wide.
With this patch the behavior is as follows. First the installer will check
whether it has write access to the system wide location ("c:\Program Files" or
"c:\Program Files (x86)"). If this fails it will fall pack on a per-user
installation.
…on existing value.
…s on existing value.
…nds on existing value.
…nd on which version of Windows is installed.
…e installation directory.
… for the default option.
simonster
added a commit
that referenced
this pull request
Nov 21, 2012
Windows: support the /S switch for restricted user accounts running silent installations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent released version does not fully support the /S switch. When a non-administrative user denies the UAC prompt, the following occurs:
With this branch much of the decision logic is moved out of NSIS pages. Default options are defined, and UI controls are set to mirror these. In cases where default options are invalid the silent installer will abort.
I've made an effort to preserve all existing behavior for normal installations. That said, this branch includes my previous pull request which changes the way the default installation location is chosen.
One remaining item for non-administrative users installing Zotero is that the uninstaller triggers a UAC prompt regardless of how Zotero was installed. I may send an additional pull request to fix this.