Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF reader: Support word lookup on macOS #2057

Closed
dstillman opened this issue May 11, 2021 · 2 comments
Closed

PDF reader: Support word lookup on macOS #2057

dstillman opened this issue May 11, 2021 · 2 comments
Assignees
Labels

Comments

@dstillman
Copy link
Member

Word lookup on macOS (I use Cmd-Ctrl-D, but I guess it's force click or three-finger tap on a trackpad) works in our textboxes, in the new note editor, in the annotation sidebar, and even in tab titles, but it doesn't work for the PDF content itself. This is true even in Fx89 with our demo online, though the official pdf.js demo works fine.

Any idea what's causing this?

https://forums.zotero.org/discussion/comment/382772/#Comment_382772

@mrtcode
Copy link
Member

mrtcode commented May 13, 2021

It's because we use our own text layer and those things aren't implemented yet. The same is with #2012.

mrtcode added a commit to zotero/reader that referenced this issue Aug 4, 2021
@mrtcode
Copy link
Member

mrtcode commented Aug 4, 2021

Although even the newest Firefox + PDF.js doesn't work as nice as Safari + PDF.js and often takes word that is next to or after the target word. Most likely this is affected by PDF.js text layer absolute positioning and transformations not playing nice with macOS. At some point I will try to optimize that text layer to work better with macOS.

@mrtcode mrtcode closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants