Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Format: Backspace after bubble should delete previous bubble #3749

Closed
dstillman opened this issue Feb 27, 2024 · 0 comments · Fixed by #3753
Closed

Quick Format: Backspace after bubble should delete previous bubble #3749

dstillman opened this issue Feb 27, 2024 · 0 comments · Fixed by #3753
Assignees
@abaevbog
Labels
Regression

Comments

@dstillman
Copy link
Member

Follow-up to #3464

If you the cursor is positioned immediately after a bubble (e.g., because you just accepted a search result to create a bubble) and you press Backspace, the previous bubble gets selected instead of deleted. You have to press Backspace a second time to delete the bubble. If there's no text to delete, I don't think there's any reason not to just delete the preceding bubble.
abaevbog added a commit to abaevbog/zotero that referenced this issue Feb 27, 2024
@abaevbog
quick-format: post-accessibility update edits
e1c2267 
- Backspace from the very beginning of the input will delete the previous
bubble, as opposed to removing the input itself. If it makes it so that
two inputs are next to each other, they are merged.
- When a new input is created via a mouse click, and the current input
is empty, manually delete it right away. Waiting for the blur handler
to remove it makes it so that the bubbles shift back and forth for a moment
when a new input is added and the old input is not removed.
- Minor tweak to make sure that even if there's a 'br' before an input,
clicking before it will not make a new input and just refocus it.

Fixes: zotero#3749
@abaevbog abaevbog mentioned this issue Feb 27, 2024
Merged
abaevbog added a commit to abaevbog/zotero that referenced this issue Feb 28, 2024
@abaevbog
quick-format: post-accessibility update edits
fb688b9 
- Backspace from the very beginning of the input will delete the previous
bubble, as opposed to removing the input itself. If it makes it so that
two inputs are next to each other, they are merged.
- When a new input is created via a mouse click, and the current input
is empty, manually delete it right away. Waiting for the blur handler
to remove it makes it so that the bubbles shift back and forth for a moment
when a new input is added and the old input is not removed.
- Minor tweak to make sure that even if there's a 'br' before an input,
clicking before it will not make a new input and just refocus it.

Fixes: zotero#3749
dstillman pushed a commit that referenced this issue Feb 28, 2024
@abaevbog
quick-format: post-accessibility update edits (#3753)
1a48e4d 
- Backspace from the very beginning of the input will delete the previous
bubble, as opposed to removing the input itself. If it makes it so that
two inputs are next to each other, they are merged.
- When a new input is created via a mouse click, and the current input
is empty, manually delete it right away. Waiting for the blur handler
to remove it makes it so that the bubbles shift back and forth for a moment
when a new input is added and the old input is not removed.
- Minor tweak to make sure that even if there's a 'br' before an input,
clicking before it will not make a new input and just refocus it.

Fixes: #3749
abaevbog added a commit to abaevbog/zotero that referenced this issue Mar 27, 2024
@abaevbog
quick-format: post-accessibility update edits (zotero#3753)
a0dff1f 
- Backspace from the very beginning of the input will delete the previous
bubble, as opposed to removing the input itself. If it makes it so that
two inputs are next to each other, they are merged.
- When a new input is created via a mouse click, and the current input
is empty, manually delete it right away. Waiting for the blur handler
to remove it makes it so that the bubbles shift back and forth for a moment
when a new input is added and the old input is not removed.
- Minor tweak to make sure that even if there's a 'br' before an input,
clicking before it will not make a new input and just refocus it.

Fixes: zotero#3749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abaevbog abaevbog

Labels
Regression
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

quick-format: post-accessibility update edits abaevbog/zotero
2 participants
@dstillman @abaevbog