-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix item pane header #4159
Merged
Merged
Fix item pane header #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: #4116 |
Partially fix: zotero#4141 Move split-menu-button styles to SCSS
windingwind
force-pushed
the
Fix-item-pane-header
branch
from
May 29, 2024 06:37
2a02f64
to
8c73174
Compare
This was
linked to
issues
May 29, 2024
Hi @yexingsha, this is what this PR looks like, please check if I missed anything: MacOS: |
Thanks. Done:
Screen.Recording.2024-05-31.at.08.48.16.mov |
This looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4141
Move split-menu-button styles to SCSS
Are the quotation marks around "My Library" necessary? I think we can remove those