Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Export Library" option for right-click context menu for group libraries #487

Closed
adam3smith opened this issue May 20, 2014 · 21 comments
Closed

Comments

@adam3smith
Copy link
Contributor

Also export the currently selected library when choosing "Export Library" from Actions menu, ideally put library name at the top of the export dialog.
https://forums.zotero.org/discussion/22217/export-zotero-group-library-to-endnote/#Item_14

@dmbortz
Copy link

dmbortz commented Jul 3, 2014

I wanted to add my support for this feature. In particular, I'd like to be able to export to bibtex, but presumably adding the "choose library" option to "export library" will resolve this issue.

D

@aurimasv
Copy link
Contributor

aurimasv commented Jul 3, 2014

Since BibTeX has no concept of collections, you would not gain anything from having a right-click -> Export Group option. You can simply select the root of whichever group you want, select all items (Ctrl/Cmd + A), right-click the selection, and choose Export.

@dmbortz
Copy link

dmbortz commented Jul 3, 2014

Hello,

I use zotero to manage the references used by my group. Accordingly, we have a "group" bibtex file that everyone uses when writing papers - hence why this would be a useful feature.

I just installed the "Zotero automatic export 1.1.8" plugin and that has the option to export collections. But, it would be nice to have it in the main program...

D

@dstillman
Copy link
Member

I'm not sure you read @aurimasv's post. While this would be helpful for some formats, it would make no difference for BibTeX, since Select All, right-click, Export Items in the library root is exactly the same.

@dmbortz
Copy link

dmbortz commented Jul 3, 2014

Our group thinks of the filename of the exported bib file as an implicit collection name. When doing the "Select All, right-click, Export Items", the name of the created file is always "Exported Items.bib". On a daily basis, group members add new entries to the group database, so the "Select All, right-click, Export Items" followed by "change the name of saved file" gets tedious (and is error prone).

As I said, this 'collection export' functionality is already implemented in the plugin by Robert Kuhn. And, maybe a 'right-click' contextual option isn't the best way to implement it...I just thought it would be more convenient if the functionality was a part of the main zotero program.

D

@adam3smith
Copy link
Contributor Author

I think we should take this back to the Zotero forums (which is generally a better place than the bug & issue tracker--essentially the only reason to post here instead of the forum is when you have a patch or would like to work on one). The ticket here doesn't have anything to do with filenaming, for example, so I'd want to figure out what exactly you're looking for to see if that'd be a separate ticket, maybe something that's already possible, or something we don't actually want to implement.

@dmbortz
Copy link

dmbortz commented Jul 3, 2014

Ok, will do.

D

@retorquere
Copy link
Contributor

If I were to write a patch to add right-click export, against what baseline would you want that? The 4.0 branch, the 4.0.26.4 tag, the master branch?

@aurimasv
Copy link
Contributor

4.0 branch

@retorquere
Copy link
Contributor

Is there a build procedure beyond zipping things up, and is there a test suite that I should pass?

@adam3smith
Copy link
Contributor Author

you'd typically run straight from the git checkout and not build while coding, but if you do want to build, zipping is all you need to do, though make sure you do have a recursive checkout, since you'll be missing a bunch of components otherwise.

Simon and Aurimas have been working on a test suite, but I don't think there's anything relevant in there yet, so you can submit without running this.

@retorquere
Copy link
Contributor

Crap, I didn't do a recursive clone. Can his still be done after the initial checkout? The patch is ready, just 50-odd lines of code.

@aurimasv
Copy link
Contributor

See https://www.zotero.org/support/dev/source_code#running_git_installations for running Zotero from source.

At this point, the test suite coverage is far from complete, but you should still run all currently available tests to make sure that your changes are not breaking anything else. You can run the tests by running runtests.sh from the "test" directory of zotero repo. It would be great if you could also write new tests for the features you are submitting, but that is not always trivial to do, so I don't think this will currenlty be enforced.

@dstillman
Copy link
Member

Crap, I didn't do a recursive clone. Can his still be done after the initial checkout?

git submodule init
git submodule update

@aurimasv
Copy link
Contributor

git submodule update --init --recursive in one step

@retorquere
Copy link
Contributor

OK, done all that (needed to start afresh anyhow as I had done a checkout from the main repo, not a clone), but when I checkout 4.0 and do zip -r /home/emile/zotero/zotero.xpi . -x *.git*, I get a sort-of-working Zotero that has no translators loaded. This is without my mods on a different branch, and after I did a "reset translators"; the translators directory remains empty. Possibly related to an error spit out on the console: https://gist.github.com/retorquere/71bac09c0cbd468e94e6

@dstillman
Copy link
Member

You can't ZIP up a Git checkout. You need to run it directly, as explained in the linked page above.

@retorquere
Copy link
Contributor

OK, will do, but @adam3smith said above I could just zip it up.

@adam3smith
Copy link
Contributor Author

sorry, my bad. I misremembered what the recursive clone does.

@retorquere
Copy link
Contributor

Hmm, the #mention of 487 didn't put a link here, but running from git worked, and a pull request is at #712. Perhaps it's waiting for the travis run to finish.

dstillman added a commit that referenced this issue May 12, 2015
@dstillman
Copy link
Member

Closed by #712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants