fix attachments row not hiding at the same time as preview #3943
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when selecting item without attachment
|
This PR looks good. btw, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
In the Item Pane, Attachments section, when selected item changes from one with attachment to one without, a minor stutter is observed.This is because there is a slight delay (~20ms) between hiding the attachment preview and the attachment row.
The attachment preview is hidden first with CSS, then the row elements are removed with JS later. There is enough delay for the browser to paint in between, resulting in a frame where the attachment rows are visible, but not the preview. The rows are removed in consequent paint, which creates visual stutter.
Description
This PR hides the entire body (both the attachments preview and the rows) at the same time via the CSS rule that used to only hide the preview.
.togglePreviewis currently not used anywhere (and doesn't seem to have been used at any time), so it doesn't affect anything.