Proper tests #11
Merged
Proper tests #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rustkas
commented
Apr 23, 2022
rustkas
commented
- Add proper tests for depcache module.
- Add launching proper test by Makefile.
- Move dializer launching to rebar3 test profile.
- Add changes to rebar.config.
Replace 3600 to the constant HOUR
Provide more information about function definitons of depcache API. Add EDoc options to API documentation (tune CSS styles, add overview file). Add new folder doc_src which contains additional files for documentation generation. Implement overload option of EDoc. Show hidden documetation by providing rebar3 option - add additional profile for EDoc private documentation. Separate some functions to make the code easier to read. Tunie Makefile: add command for edoc, clean; add new command edoc_private
Refactor some -spec descriptions. Made some refactoring to explicely transform data.
It is possible that input Key and dict Key is not the some.
Add proper tests for depcache module. Add launching proper test by Makefile. Move dializer launching to rebar3 test profile. Add changes to rebar.config.
|
It seems that proper doesn't support OTP 19, I am ok with removing that test target. |
Ok. |
The setting of the configuration file that did not work during automatic testing was removed.
Update OTP version list which is supported.
|
Maybe just remove the whole OTP 19.3 tests from the .GH tests? depcache/.github/workflows/test.yml Line 21 in 888445a And then, maybe, add OTP 24? |
|
Just checked manually, and indeed 20.3 and 23 both pass the tests. |
Yes. Of couse. |
|
Everything passes 🥳 Merging! And thank you again! |
|
Released version 1.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.