Use structured logging #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mworrell
reviewed
Apr 13, 2022
src/template_compiler.erl
Outdated
| @@ -196,7 +196,7 @@ block_lookup({ok, TplFile}, BlockMap, ExtendsStack, DebugTrace, Options, Vars, R | |||
| case lists:member(Module, ExtendsStack) of | |||
| true -> | |||
| FileTrace = [Module:filename() | [ M:filename() || M <- ExtendsStack ]], | |||
| ?LOG_ERROR("[template_compiler] Template recursion: ~p", [FileTrace]), | |||
| ?LOG_ERROR(#{ text => "Template recursion.", trace => FileTrace}), | |||
There was a problem hiding this comment.
Just an idea, could we transform the trace to a stack trace format? Then the logger can show it as a stack trace.
There was a problem hiding this comment.
Probably.. I want to change the yecc errors top maps as well. That will probably improve the readability. Not sure what a filetrace looks like tbh.
There was a problem hiding this comment.
Would be great, the Yecc errors are quite confusing. We should be able to see in one go what the problem is and where.
mworrell
reviewed
Apr 13, 2022
src/template_compiler.erl
Outdated
| Error | ||
| end; | ||
| error -> | ||
| ?LOG_ERROR("Error compiling forms for ~p", [Filename]), | ||
| ?LOG_ERROR(#{ text => "Error compiling forms.", filename => Filename}), |
There was a problem hiding this comment.
In the other logging I always added result => error and then, if known, reason => ...
vkatsuba
reviewed
May 30, 2022
vkatsuba
reviewed
May 30, 2022
mworrell
force-pushed
the
structured-logging
branch
from
f43c21b
to
1d7f4b1
Compare
|
Rebased on master |
Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
|
Yeah nice... Only the yecc errors are still confusing. :p |
Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
Co-authored-by: Viacheslav Katsuba <v.katsuba.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes log messages to structured logging format.