Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic compilation of Sass files #1431

Closed
ddeboer opened this issue Sep 8, 2016 · 7 comments
Closed

Automatic compilation of Sass files #1431

ddeboer opened this issue Sep 8, 2016 · 7 comments

Comments

@ddeboer
Copy link
Member

ddeboer commented Sep 8, 2016

Zotonic automatically compiles LESS to CSS. At Driebit we happen to use Sass.

Would adding Sass support to the automatic compilation be useful for others, as well?

@mworrell
Copy link
Member

mworrell commented Sep 8, 2016

+1 Sass is used by quite some people and adding support is easily done by handling the .sass extension. I would suggest to handle it in a similar way (config etc) as we do with Less.

@mworrell
Copy link
Member

mworrell commented Sep 8, 2016

BTW maybe we could handle files extensible? Using a first notifier would be enough, as that would create a new file, which triggers another file-change notification.

@ddeboer
Copy link
Member Author

ddeboer commented Sep 8, 2016

A notification is a good idea. We also need to account for some config (e.g. inclusion paths, minification flags). It seems the LESS support already does so.

@mworrell
Copy link
Member

mworrell commented Sep 8, 2016

LESS support works smoothly, so indeed just copy the behavior, but then for SASS.

The notification can be added later in a refactor of the file handling code.

@arjan
Copy link
Member

arjan commented Sep 8, 2016

I uses SASS all the time already with Zotonic, although I use the .scss variants and not the weird yaml sass syntax. SCSS works fine, all files in lib/scss automatically get compiled into lib/css.

@ddeboer
Copy link
Member Author

ddeboer commented Sep 8, 2016

Lol, Zotonic already compiles .scss. I’ll have a look at the current functionality and see if anything is missing there.

@arjan arjan closed this as completed Sep 8, 2016
@Devenwel
Copy link

Devenwel commented Sep 8, 2016

We do use some npm packages in gulp to transform the output in our sites, like postCSS/Lost, autoprefixer, so that would have to keep working as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants