New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod_export] Observe content disposition #1847

Merged
merged 2 commits into from Nov 9, 2017

Conversation

Projects
None yet
3 participants
@fredpook
Contributor

fredpook commented Nov 9, 2017

Rss feeds are currently handled by browsers as a download while the Rss reader plugins want Content-Disposition inline.
This PR allows Content-Disposition to be inline instead of attachment.
It also fixes a problem with unpublished resources to show up in feeds.

@fredpook fredpook changed the base branch from master to 0.x Nov 9, 2017

@ddeboer

👍 for the change in general. Can you fix some details before we merge this?

@ddeboer

This comment has been minimized.

Show comment
Hide comment
@ddeboer

ddeboer Nov 9, 2017

Member

LGTM now. @mworrell Please have a look and squash & merge if okay.

Member

ddeboer commented Nov 9, 2017

LGTM now. @mworrell Please have a look and squash & merge if okay.

@ddeboer

ddeboer approved these changes Nov 9, 2017

@mworrell mworrell merged commit c80f00f into zotonic:0.x Nov 9, 2017

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

mworrell added a commit that referenced this pull request Nov 9, 2017

@ddeboer ddeboer added this to the 0.35 milestone Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment