[mod_export] Observe content disposition #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeboer
requested changes
Nov 9, 2017
| ], | ||
| {Bin, _Context} = z_template:render_to_iolist({cat, "atom/entry.tpl"}, Vars, Context), | ||
| {ok, iolist_to_binary(Bin), State}; | ||
| case m_rsc:p(Row, is_published, Context) of |
There was a problem hiding this comment.
@mworrell Should we add an ACL check here? If so, it should be is_visible.
| undefined -> | ||
| Cat = m_rsc:p_no_acl(Id, category, Context), | ||
| Filename = "export-" | ||
| Filename2 = "export-" |
There was a problem hiding this comment.
The Filename variable should be moved before the case:
Filename = case z_notifier:first(#export_resource_filename{id=Id, dispatch=Dispatch, content_type=ContentType}, Context) of
undefined ->
...
|
LGTM now. @mworrell Please have a look and squash & merge if okay. |
ddeboer
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rss feeds are currently handled by browsers as a download while the Rss reader plugins want Content-Disposition inline.
This PR allows Content-Disposition to be inline instead of attachment.
It also fixes a problem with unpublished resources to show up in feeds.