-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging of system/acl events in mod_logging #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ddeboer Can you give this a test run? |
mworrell
changed the title
WIP: Logging of system events in mod_logging
Logging of system/acl events in mod_logging
May 6, 2019
ddeboer
reviewed
May 6, 2019
ddeboer
reviewed
May 6, 2019
Just pushed a fix for the status page, which breaks at |
mworrell
commented
May 6, 2019
Which config was set by the status? We could also check on having a db connection, and if not then return an error code from the config-set |
Ratelimit at the status login:
Checking db conn is probably better; feel free to change! |
Change log level of module and config changes
ddeboer
approved these changes
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This re-uses mod_logging to log more system related events:
Known Issues
Checklist