Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: on rsc update error for expected version, return error (0.x) #3322

Merged
merged 1 commit into from
Mar 15, 2023
Merged

core: on rsc update error for expected version, return error (0.x) #3322

merged 1 commit into from
Mar 15, 2023

Conversation

mworrell
Copy link
Member

Description

Do not throw an exception, as this expectation should be programmatically handled.

Checklist

  • documentation updated
  • tests added
  • no BC breaks

@mworrell
core: on rsc update error for expected version, return error
254a1be 
Do not throw an exception, as this expectation should be programmatically handled.
@mworrell mworrell added this to the 0.76.0 milestone Mar 14, 2023
@mworrell mworrell requested a review from mmzeeman March 14, 2023 10:49
@mworrell mworrell changed the title core: on rsc update error for expected version, return error core: on rsc update error for expected version, return error (0.x) Mar 15, 2023
mmzeeman
mmzeeman approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@mmzeeman mmzeeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ook prima.

@mworrell
Copy link
Member Author

In the master branch we don't throw exceptions anyway.
And in the case of failed expectations it is better to have return values, so it is possible to handle the failure in a programmatic way.

@mworrell mworrell merged commit 8c98467 into 0.x Mar 15, 2023
@mworrell mworrell deleted the rsc-update-expected branch March 15, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmzeeman mmzeeman mmzeeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.76.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mworrell @mmzeeman